search

CUL-DigitalServices / libraries-gateway

Cambridge Libraries
1 stars 4 forks source link

Added separate templates for Aquabrowser and Summon #232

Closed Coenego closed 10 years ago

Coenego commented 10 years ago

Each item in the results list (shortrecords) has it's own template, depending on which API has been specified. Currently, we are still using the predefined models to populate the templates. This will change to dynamic models where all the retrieved metadata will be stored (so we will not be making a manual selection of properties any longer). This will allow us to generate format-specific templates, populated by the given metadata.

Coenego commented 10 years ago

Assigning to @timdegroote for review

timdegroote commented 10 years ago

Finished reviewing, reassigning to @Coenego for follow-up.

Coenego commented 10 years ago

Follow-up done, reassigning to @timdegroote

ucamhal commented 10 years ago

Made some subjective comments for you to consider @Coenego :)

Coenego commented 10 years ago

Reassigning to @ucamhal for review on follow-up. As discussed with @ucamhal , I'll create a separate PR for the changes concerning the getContent comment.

ucamhal commented 10 years ago

Looks good, thanks.

Coenego commented 10 years ago

@ucamhal , can you create a separate ticket for the getContent issue?