CUModSquad / Camelot-Unchained

UI repository for Camelot Unchained, a tri-realm RvR MMORPG.
Mozilla Public License 2.0
7 stars 25 forks source link

trigger the shine effect, when the progress bar is at 100% #282

Closed UmbarPantera closed 5 years ago

UmbarPantera commented 5 years ago

not tested in the client!!! I couldn't find a server, that allows a custom UI.

The problem: When the test for the progress bar were done, the progress was increased by 1% each step. Currently in the client the progress increases by 20% each step. This makes something visible you could not see before.

When props.progress is at 100(%), the progress bar is still one step before 100% and starts its transition to 100%. If you increase props.progress by 1%, one step before 100% is 99%. If you increase it by 20%, the progress bar is at 80%, when props.progress is at 100. But if props.progress is at 100, the shine effect start. If the progress bar is at 99%, when the shine effect starts, everything is ok. In the other case the progress bar actually is at 80%, when the shine effect starts. It beginns outside of the progress bar. It looks more like bug than a shine effect on the progress bar.

I have changed the code. If props.progress is at 100 I am adding an event listener now. It gets triggered, when the transition is completed, which means the progress bar has actually reached 100%.

It works in a Chrome Browser.

I don't know if it works with Coherent and if "transitionend" is the correct event for Coherent.

UmbarPantera commented 5 years ago

The progress bar was replaced