search

CUModSquad / Camelot-Unchained

UI repository for Camelot Unchained, a tri-realm RvR MMORPG.
Mozilla Public License 2.0
7 stars 25 forks source link

Things I needed to get this to compile #287

Open krugar opened 5 years ago

krugar commented 5 years ago

Additionally to what's in the PR,

I had to manually run npm i --save @csegames/camelot-unchained in Camelot-Unchained/game/hud, as that correctly uses the private registry, even if yarn doesn't.

I also had to set "forceConsistentCasingInFileNames": false in my tsconfig.json to squash TS1149 errors with import statements from hud/..., due to the directory on disk being named HUD.

I've not included either in the PR because it might be somehow specific to my setup here.

sysrage commented 5 years ago

Since yarn was ignoring the private registry in .npmrc, we tried adding the following to .yarnrc:

"@csegames:registry" "http://registry.camelotunchained.com"

This doesn't seem to work.

sysrage commented 5 years ago

While working with Salty, we found that everything breaks again if Node is upgraded to 12.x. The above workarounds only work with Node 10.x.

krugar commented 5 years ago

Right, I should have stated that I tried this with LTS/Dubnium (v10.17.0 at time of writing), given that the project requires v7.4.X, which I would read as LTS/Carbon (v8.16.2 atm)?

edit: btw, CircleCI failed because hatcheryapi was down broken at the time:

@csegames/camelot-unchained: nps is executing definitions : download https://hatcheryapi.camelotunchained.com/codegen/definitions.ts > ./src/webAPI/definitions.ts @csegames/camelot-unchained: HTTPError: Response code 500 (Internal Server Error)