search

CUNY-CL / latin_scansion

Apache License 2.0
0 stars 2 forks source link

meter grammar edits #34

Closed jillianchang closed 3 years ago

jillianchang commented 3 years ago

For the name "Phthīam", should I allow "Phth" as an onset?

kylebgorman commented 3 years ago

Pronunciation should change that to [pt], which is a valid onset but only for Greek borrowings. So yes.

On Mon, Aug 9, 2021 at 9:32 PM jillianchang @.***> wrote:

For the name "Phthīam", should I allow "Phth" as an onset?

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/34#issuecomment-895660888, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OPKASBGOVDYTNWGQFDT4B6SHANCNFSM5B26JFQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

kylebgorman commented 3 years ago

Yes, that'd work.

On Tue, Aug 10, 2021 at 2:37 PM jillianchang @.***> wrote:

@.**** commented on this pull request.

In grammars/Makefile https://github.com/CUNY-CL/LatinScansion/pull/34#discussion_r686227615:

@@ -1,28 +1,14 @@ -all: all.far

-all.far: all.grm meter.far normalize.far pron.far variable.far

  • thraxcompiler --input_grammar=$< --output_far=$@

  • -meter.far: meter.grm byte.far inventory.far utility.far +meter.far: meter.grm inventory.far byte.far utility.far

I can't figure out how to revert changes. Is the grammar/Makefile on our current master branch the one we want? If so, I can just copy and paste all of that into this branch

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/34#discussion_r686227615, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4ONY55QG6LBG5WABS2DT4FWVPANCNFSM5B26JFQQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .

jillianchang commented 3 years ago

Does this look okay to be merged?