kylebgorman
commented
3 years ago That looks like you did things right except the bit about line.meter
doesn't make any sense: we haven't defined a meter field yet.
The assertion failure is saying that the pronunciation string is empty, which happens when one of the compositions fails.
To see what the error was, comment out the second-to-last line in
scansion_test.py (the one that reads logging.disable("CRITICAL")) and
re-run.
On Sat, Aug 14, 2021 at 8:09 PM jillianchang @.***> wrote:
@.**** commented on this pull request.
In grammars/meter.grm https://github.com/CUNY-CL/LatinScansion/pull/39#discussion_r689007138:
@@ -66,7 +72,13 @@ test_scan_3 = AssertEqual[
"kwidwe doleːns reːgiːna deũː tot wolwere kaːsuːs" @ METER,
"DSDSDS"
];
+# Muta cum liquida is split.
test_scan_4 = AssertEqual[
"kekropidaj jussiː miserũː septeːna kwotanniːs" @ METER,
"DSDSDS"
];
Is this right for adding unit tests?
def test_aen_6_21(self): # Scans line 6.21. text = "Cecropidae jussī (miserum!) septēna quotannīs" line = self.scan_line(text, 21) self.assertEqual(line.line_number, 21) self.assertEqual(line.text, text) self.assertEqual( line.norm, "cecropidae jussī miserum septēna quotannīs" ) self.assertEqual( line.pron, "kekropidaj jussiː miserũː septeːna kwotanniːs" ) self.assertEqual( line.meter, "DSDSDS" )I'm getting this for the pron part:
Traceback (most recent call last):
File "scansion_test.py", line 49, in test_aen_6_21
self.assertEqual(AssertionError: '' != 'kekropidaj jussiː miserũː septeːna kwotanniːs'
- kekropidaj jussiː miserũː septeːna kwotanniːs
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/39#discussion_r689007138, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OOVVVNXI7NIHHZVRYDT44ATJANCNFSM5CCJIGTQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email .
jillianchang
I know that there's something wrong with this new edit, since the combined grammar isn't able to scan lines as it used to. Do you have suggestions for how to improve this current meter grammar to allow the "variable" behavior?
Additionally, I had to delete all the intermediary tests, because I think the 'opt' and weight in the new muta cum liquida rule messes that up (?)