search

CUNY-CL / latin_scansion

Apache License 2.0
0 stars 2 forks source link

added some unit tests for composition failures in books 3-6 #52

Closed jillianchang closed 3 years ago

jillianchang commented 3 years ago

I checked in the lines that require more attention for grammar development. I had some uncertainties about how to scan some of the lines themselves (they're marked with the comment "Not sure how to scan"). I also have some questions about how I should modify the grammar - could you offer your insights as per the below comments?

jillianchang commented 3 years ago

I'm in Hawaii right now, and I didn't bring the Pharr book with me. If you have it on you, could you check on these lines?

3.464 'dōna dehinc aurō gravia sectōque elephantō' - is there an "ac" after "gravia"? 3.549 'cornua vēlātārum obvertimus antemārum' - is the "e" in antemārum micronized? 5.352 'dat salīo villīs onerōsum atque unguibus aureīs' - is the macron placement saliō instead? 5.870 'ō nimium caelō et pelagō cōnfise serēnō' - does the "i" in cōnfise have a macron?

kylebgorman commented 3 years ago

I'll work through these over the weekend at the latest---nice stuff.

jillianchang commented 3 years ago

Do you know how to scan these? "īdem ventūrōs tollemus in astra nepōtēs" "ter spūmam ēlisam et rōrantia vīdimus astra." "(hoc solum nōmen quoniam dē conjuge restat)?" '"Ō nimium caelō et pelagō cōnfise serēnō'

kylebgorman commented 3 years ago
kylebgorman commented 3 years ago

I don't have Pharr in front of me but I can answer these questions in how they ought to be at least:

3.464 'dōna dehinc aurō gravia sectōque elephantō' - is there an "ac" after "gravia"?

Not in Pharr but apparently that's an incorrect recension and it should be dōna dehinc aurō gravia ac sectō elephantō.

3.549 'cornua vēlātārum obvertimus antemārum' - is the "e" in antemārum micronized?

The word should be antemnārum (or its metrical equivalent/variant _antennārum) it seems. antemārum is gibberish.

5.352 'dat salīo villīs onerōsum atque unguibus aureīs' - is the macron placement saliō instead?

I know it is from first principles it has to be: Latin words don't end in short-o and if there is a hiatus only the second vowel can be long.

5.870 'ō nimium caelō et pelagō cōnfise serēnō' - does the "i" in cōnfise have a macron?

Yes.

kylebgorman commented 3 years ago

Probably can’t parse onset if I had to guess. (Shouldn’t this be realized as [n] anyways?)

On Fri, Sep 3, 2021 at 11:26 PM jillianchang @.***> wrote:

@.**** commented on this pull request.

In src/scansion_test.py https://github.com/CUNY-CL/LatinScansion/pull/52#discussion_r702227251:

@@ -292,9 +283,8 @@ def test_aen_5_306(self):

         line.pron, "ŋnoːsia biːna daboː leːwaːtoː luːkida ferroː"

     )

  • Diaresis of "ī".

Okay, so now all these tests pass, except for this one but I couldn't figure out why.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/52#pullrequestreview-746536228, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OMCOZWR7WGV27LAAPDUAGGU3ANCNFSM5C4ELL4A . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jillianchang commented 3 years ago

Oh sorry, I meant to refer to the test after the comment.

jillianchang commented 3 years ago 
def test_aen_5_352(self):
         text = "dat Saliō villīs onerōsum atque unguibus aureiːs."
         line = self.scan_line(text)
         self.assertEqual(
             line.pron, "dat salioː williːs oneroːsatkwuŋgwibu sawrejs"
        )
jillianchang commented 3 years ago

Oh, it was the "ː." Tests are good now.

jillianchang commented 3 years ago

Can I merge these so I could use them in the markup testing too?