search

CUNY-CL / latin_scansion

Apache License 2.0
0 stars 2 forks source link

Added synizesis and diaeresis markups #60

Open jillianchang opened 3 years ago

jillianchang commented 3 years ago

Are you talking about the inventory changes? I’m not sure if those will.

kylebgorman commented 3 years ago

Are you talking about the inventory changes? I’m not sure if those will.

No, those belong here, I just meant the changes to the files in data/Aeneid.

jillianchang commented 3 years ago

Yes, those are already in master.

On Sep 6, 2021, at 3:18 PM, Kyle Gorman @.***> wrote:

Are you talking about the inventory changes? I’m not sure if those will.

No, those belong here, I just meant the changes to the files in data/Aeneid.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/60#issuecomment-913820450, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANYD7FZR37R336Q6XFYN44LUAUH2BANCNFSM5DNOOWYQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kylebgorman commented 3 years ago

Yes, those are already in master. … On Sep 6, 2021, at 3:18 PM, Kyle Gorman @.***> wrote: Are you talking about the inventory changes? I’m not sure if those will. No, those belong here, I just meant the changes to the files in data/Aeneid. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#60 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANYD7FZR37R336Q6XFYN44LUAUH2BANCNFSM5DNOOWYQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

Thought so, go ahead and merge then.

kylebgorman commented 3 years ago

Is this ready to go in?

jillianchang commented 3 years ago

There's still the issue about the handling of the synizesis markup.

kylebgorman commented 3 years ago

If that works, SGTM. I wish I had an idea myself...

K

On Mon, Sep 13, 2021 at 5:06 PM jillianchang @.***> wrote:

@.**** commented on this pull request.

In grammars/meter.grm https://github.com/CUNY-CL/LatinScansion/pull/60#discussion_r707680991:

@@ -19,9 +19,9 @@ delete_strikethrough_undertie = Optimize[u.Rewrite[u.Delete[i.STRIKETHROUGH | "

Removes the ligature tie and rewrites "i" or "u" to "j" or "w," respectively.

synizesis_cleanup = Optimize[

CDRewrite[(("i" | "iː") : "j") | (("u" | "uː") : "w"), "͡", "", sigma_star] @

  • CDRewrite[(("i" | "iː") : "j") | (("u" | "uː") : "w"), "", "͡", sigma_star] @

  • u.Rewrite[u.Delete["͡"], sigma_star]

-];

  • CDRewrite[(("i" | "iː") : "j") | (("u" | "uː") : "w"), "", "͡", sigma_star] @

  • u.Rewrite[u.Delete["͡"], sigma_star]

  • ];

This reminds me of the muta cum liquida phenomena, where we split consonant clusters only optionally. Similarly, I was thinking the approach will be to let the grammar choose based on composition which "I" to rewrite to j (if the ligature tie encompasses two "I"s), and if the ligature tie encompasses both a "u" and an "I", then also let it decide which one will make the meter work.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/60#discussion_r707680991, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4ONX4TSUHMJLNPQ367LUBZRU7ANCNFSM5DNOOWYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jillianchang commented 3 years ago

• Handling of synizesis: added i.PHONEMIC_VOWEL to the right / left contexts of the synizesis_cleanup rule, which fixes the previous issue of the grammar not knowing which "I" to rewrite to "j" (if two "I"s are under the ligature tie), or which of "u" or "I" to rewrite (if those two are adjacent) • Arranged elision after diaeresis in the variable composition sequence, in order to allow danaum (danawm) to apply diaeresis -> danaüm, but to also elide into the next adjacent vowel-beginning word.

jillianchang commented 3 years ago

Yes, seems like it.

On Sep 15, 2021, at 9:26 AM, Kyle Gorman @.***> wrote:

@kylebgorman approved this pull request.

LGTM, did that solve it?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/60#pullrequestreview-755117769, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANYD7F43BP5P56ZPAFYPPL3UCCNJTANCNFSM5DNOOWYQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jillianchang commented 3 years ago

Alright, this is done I think. Should we make this the master version now?

kylebgorman commented 3 years ago

Hold off just a few days on that. I want to see if I can get my back-end changes in first...I think it might be easier to migrate that way.

K

On Wed, Sep 15, 2021 at 7:46 PM jillianchang @.***> wrote:

Alright, this is done I think. Should we make this the master version now?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/60#issuecomment-920465845, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OP3TRKK3SRJMTNUTWLUCEV37ANCNFSM5DNOOWYQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.