search

CUNY-CL / latin_scansion

Apache License 2.0
0 stars 2 forks source link

Remove unused rewriter.py #66

Closed kylebgorman closed 3 years ago

jillianchang commented 3 years ago

The rewriter script is actually helpful for me to output the pronunciation of an entire book, which I can use when I do certain tests. Can we keep it for now? Unless, is there another way to accomplish the same thing?

kylebgorman commented 3 years ago

If you're still using it, okay, sure. Let's leave this as is. I'll close the PR but we can reopen it if needed.

kylebgorman commented 3 years ago

On reflection, there is another way to do that: this is what scan.py does. The textproto files it generates are human-readable markup for entire books. Could you try that out and see if it does what you need? If so I will then reopen and merge this issue.

jillianchang commented 3 years ago

Ah, it generates the normalized version and the final pronunciation (with variable rules applied), but not the post pron version before variable rules are applied.

On Sep 15, 2021, at 10:01 AM, Kyle Gorman @.***> wrote:

On reflection, there is another way to do that: this is what scan.py does. The textproto files it generates are human-readable markup for entire books. Could you try that out and see if it does what you need? If so I will then reopen and merge this issue.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/66#issuecomment-920046567, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANYD7F3BC2DRJPJKGCA5AI3UCCRMRANCNFSM5D6UQKJQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kylebgorman commented 3 years ago

Do you need that? If so I can make it so the intermediate pronunciation is also stored, if that's something you're using often.

On Wed, Sep 15, 2021 at 7:05 PM jillianchang @.***> wrote:

Ah, it generates the normalized version and the final pronunciation (with variable rules applied), but not the post pron version before variable rules are applied.

On Sep 15, 2021, at 10:01 AM, Kyle Gorman @.***> wrote:

On reflection, there is another way to do that: this is what scan.py does. The textproto files it generates are human-readable markup for entire books. Could you try that out and see if it does what you need? If so I will then reopen and merge this issue.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub < https://github.com/CUNY-CL/LatinScansion/pull/66#issuecomment-920046567>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ANYD7F3BC2DRJPJKGCA5AI3UCCRMRANCNFSM5D6UQKJQ . Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/66#issuecomment-920450033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OL3PHDM74TNTXMVOEDUCERD5ANCNFSM5D6UQKJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

jillianchang commented 3 years ago

That would be helpful!

On Sep 16, 2021, at 12:43 PM, Kyle Gorman @.***> wrote:

 Do you need that? If so I can make it so the intermediate pronunciation is also stored, if that's something you're using often.

On Wed, Sep 15, 2021 at 7:05 PM jillianchang @.***> wrote:

Ah, it generates the normalized version and the final pronunciation (with variable rules applied), but not the post pron version before variable rules are applied.

On Sep 15, 2021, at 10:01 AM, Kyle Gorman @.***> wrote:

On reflection, there is another way to do that: this is what scan.py does. The textproto files it generates are human-readable markup for entire books. Could you try that out and see if it does what you need? If so I will then reopen and merge this issue.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub < https://github.com/CUNY-CL/LatinScansion/pull/66#issuecomment-920046567>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/ANYD7F3BC2DRJPJKGCA5AI3UCCRMRANCNFSM5D6UQKJQ . Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/66#issuecomment-920450033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OL3PHDM74TNTXMVOEDUCERD5ANCNFSM5D6UQKJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

kylebgorman commented 3 years ago

Okay, approve #67 and I'll add that for you.

On Thu, Sep 16, 2021 at 5:30 PM jillianchang @.***> wrote:

That would be helpful!

On Sep 16, 2021, at 12:43 PM, Kyle Gorman @.***> wrote:

 Do you need that? If so I can make it so the intermediate pronunciation is also stored, if that's something you're using often.

On Wed, Sep 15, 2021 at 7:05 PM jillianchang @.***> wrote:

Ah, it generates the normalized version and the final pronunciation (with variable rules applied), but not the post pron version before variable rules are applied.

On Sep 15, 2021, at 10:01 AM, Kyle Gorman @.***> wrote:

On reflection, there is another way to do that: this is what scan.py does. The textproto files it generates are human-readable markup for entire books. Could you try that out and see if it does what you need? If so I will then reopen and merge this issue.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <

https://github.com/CUNY-CL/LatinScansion/pull/66#issuecomment-920046567>, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ANYD7F3BC2DRJPJKGCA5AI3UCCRMRANCNFSM5D6UQKJQ

. Triage notifications on the go with GitHub Mobile for iOS <

https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android <

https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/CUNY-CL/LatinScansion/pull/66#issuecomment-920450033>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AABG4OL3PHDM74TNTXMVOEDUCERD5ANCNFSM5D6UQKJQ

. Triage notifications on the go with GitHub Mobile for iOS < https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675

or Android < https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub .

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/LatinScansion/pull/66#issuecomment-921267367, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OO5CUVWZQASEXVKMNTUCJOXPANCNFSM5D6UQKJQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

kylebgorman commented 3 years ago

Starting a new one.