search

CUNY-CL / latin_scansion

Apache License 2.0
0 stars 2 forks source link

foot and syllable tests for Aeneid 1.1 #78

Closed jillianchang closed 2 years ago

jillianchang commented 2 years ago

Is this right? There's a lot of repeated code, so if it's redundant, maybe I can try iterating non-manually.

kylebgorman commented 2 years ago

It is pretty redundant, but so it goes.

Could you also test the contents of the syllables? Each syllable has a onset, nucleus, and coda string attribute.

kylebgorman commented 2 years ago

PS, merging this in Git is going to be annoying. I would do it by starting a new branch based on the current master. Note that the scansion_pb2 namespace when referring to the proto messages is no longer necessary or supported.

kylebgorman commented 2 years ago

Exacrtly what I had in mind...thank you. Yeah it's long and pedantic but it's good to have a change-detector test or two given how complex the grammars are.

Have fun trying to merge that with head ;)

jillianchang commented 2 years ago

Closing in favor of #84.