search

CUNY-CL / latin_scansion

Apache License 2.0
0 stars 2 forks source link

Aeneid textproto comments #97

Closed jillianchang closed 2 years ago

jillianchang commented 2 years ago

There are a few lines that require further investigation as to why it was scanned as defective, I will look into it. Let me know about your preferences for comment wording, and I can apply those across the other files as well.

jillianchang commented 2 years ago

Just a note that when writing the new pron for diastole comments, I wrote out the word whole, even if elision occurs.

jillianchang commented 2 years ago

Is there a way to produce a new textproto file (aka running latin_scan) while preserving the old comments, and avoiding the need to reinsert them every time we generate run a new scan?

kylebgorman commented 2 years ago

No such obvious tool exists, so we will perhaps want to make one. I do not suppose it will be terribly challenging, it's mostly a question of thinking what the API ought to be (e.g., how does one pass in files etc.).

On Sun, Mar 6, 2022 at 12:10 AM jillianchang @.***> wrote:

Is there a way to produce a new textproto file (aka running latin_scan) while preserving the old comments, and avoiding the need to reinsert them every time we generate run a new scan?

— Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/latin_scansion/pull/97#issuecomment-1059896741, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OKFQ5VJYJNSEG535S3U6Q44HANCNFSM5PKZGW5Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

kylebgorman commented 2 years ago

Is this ready to merge?

jillianchang commented 2 years ago

After the pronunciation change gets implemented, I think I’m going to have to rerun the engine to generate new textproto files for Aeneid 1 and Aeneid 2, as the change should cause several of the now invalid scans to scan properly. I believe I would have to manually transfer these comments after rerunning? In that case, do you want to merge now or after that is done?

On Apr 2, 2022, at 6:18 PM, Kyle Gorman @.***> wrote:

 Is this ready to merge?

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

kylebgorman commented 2 years ago

After the pronunciation change gets implemented, I think I’m going to have to rerun the engine to generate new textproto files for Aeneid 1 and Aeneid 2, as the change should cause several of the now invalid scans to scan properly. I believe I would have to manually transfer these comments after rerunning? In that case, do you want to merge now or after that is done? … On Apr 2, 2022, at 6:18 PM, Kyle Gorman @.***> wrote:  Is this ready to merge? — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

I'm okay with us figuring out how to transfer the comments when we get to that point, so I'll merge.