search

CUNY-CL / latin_scansion

Apache License 2.0
0 stars 2 forks source link

changes ordering of dipthonization and nasalization in pronunciation.grm #98

Closed jillianchang closed 2 years ago

jillianchang commented 2 years ago

This fixes the scansion errors I was talking about when adding textproto comments. Previously, "Danaum" was mapped to "danawm," but in all instances the w does not glide.

kylebgorman commented 2 years ago

I owe you a response on this in the next few days, sorry for delay. I just have to bust out the pencil and paper and think about it a bit...

On Thu, Mar 3, 2022 at 7:06 PM jillianchang @.***> wrote:

@.**** commented on this pull request.

In grammars/pronounce.grm https://github.com/CUNY-CL/latin_scansion/pull/98#discussion_r819164400:

test_pron_19 = AssertEqual[

 "aut pelagō danaum īnsidiās suspectaque dōna" @ PRONOUNCE,

  • "awt pelagoː danawm iːnsidiaːs suspektakwe doːna"

  • "awt pelagoː danaũː iːnsidiaːs suspektakwe doːna"

Do you have new opinions on this?

— Reply to this email directly, view it on GitHub https://github.com/CUNY-CL/latin_scansion/pull/98#discussion_r819164400, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABG4OOZQ7FOLDXL73I75UTU6FHX3ANCNFSM5POA5A4Q . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

kylebgorman commented 2 years ago

Okay, sorry, I have one more question, sorry to be such an annoyance on this.

This is currently implemented as a variable diaeresis rule. Is there a reason nasalization-before-diphthongization can't be implemented as mandatory, applying in pronounce.grm? If that is a correct description it's certainly cleaner.

jillianchang commented 2 years ago

Okay, sorry, I have one more question, sorry to be such an annoyance on this.

This is currently implemented as a variable diaeresis rule. Is there a reason nasalization-before-diphthongization can't be implemented as mandatory, applying in pronounce.grm? If that is a correct description it's certainly cleaner.

I think you are right on that. I already had the nasalization-before-diphthonizaiton, so what I did is remove the au variable rule. It should be good to go now.