Pass subprocess return status to W&B using subprocess.Popen

CUNY-CL / udtube

Neural morphological analyzer

Apache License 2.0

3 stars 3 forks source link

Pass subprocess return status to W&B using subprocess.Popen #66

Closed jondoglover closed 2 days ago

jondoglover commented 6 days ago

W&B should now almost always correctly display whether a run failed or was successful and also display relevant error information in the W&B log.
subprocess.Popen and subprocess.run were both considered. Although cleaner and simpler, subprocess.run often fails to capture the stack trace, so subprocess.Popen is a better option.

jondoglover commented 5 days ago

Thanks for all the suggestions! I’ve implemented most of the changes, though I kept the while loop since subprocess.Popen is non-blocking. Otherwise, I simplified it significantly for better clarity and efficiency. Please let me know if there’s anything else that should be adjusted.