search

CUNY-CL / wikipron

Massively multilingual pronunciation mining
Apache License 2.0
320 stars 71 forks source link

Regenerated English data #555

Closed annapiab closed 2 months ago

annapiab commented 2 months ago
annapiab commented 2 months ago

Hi Kyle,

I updated these, but the CircleCI tests keep failing. Is there anything else I should try?

Best, Annapia.

Da: Kyle Gorman @.> Data: domenica, 1 settembre 2024 alle ore 12:18 PM A: CUNY-CL/wikipron @.> Cc: Annapia Borraccino @.>, Author @.> Oggetto: [EXTERNAL]Re: [CUNY-CL/wikipron] Regenerated English data (PR #555) ATTENTION: This email came from an external source. Do not open attachments or click on links from unknown senders or unexpected emails.

@kylebgorman commented on this pull request.

So this looks pretty good. Here a few things to address. Once you do, I'll spot-check the new data and then we should be done.

  1. As indicated in the PR description, you need to update the CHANGELOG.md file (it should be obvious what to do there, just follow the format and keep it brief) and click the checkbox in the PR description above. (then add, commit and push)
  2. The test that is failing is saying the summary data is not up to date with what you're checking in. To fix that (hopefully), navigate to data/scrape and run ./postprocess then check in (add commit push) the affected files (should be a single TSV file and the README in that directory)
  3. Please remove unscraped.json from the PR (git rm it then commit and push).

— Reply to this email directly, view it on GitHubhttps://github.com/CUNY-CL/wikipron/pull/555#pullrequestreview-2274451310, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BCHLDD4ENO4D4KE6IBFMS33ZUM46TAVCNFSM6AAAAABNO6BKI2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDENZUGQ2TCMZRGA. You are receiving this because you authored the thread.Message ID: @.***>

annapiab commented 2 months ago

Hi Kyle, I have tried reverting the changes in languages.json, but no matter what I do git status is always telling me working tree clean, so I am assuming nothing changes. I am sure of the path too. Is there an another alternative?

kylebgorman commented 2 months ago

Hi Kyle, I have tried reverting the changes in languages.json, but no matter what I do git status is always telling me working tree clean, so I am assuming nothing changes. I am sure of the path too. Is there an another alternative?

I just went in on GitHub and manually reverted the changes to languages.json. Will merge if the tests pass.

kylebgorman commented 2 months ago

So, I see a test failing right now but I am for unrelated reasons certain it has nothing to do with your PR. (In fact it's happening at head.) Since that's the only test failure I see, I will now merge. Thanks for the submission.

annapiab commented 2 months ago

I was trying to look into it as well, but I am unsure of what the issue might have been. Thanks for your help, Kyle!