Fixes several pointer-generator lstm bugs

CUNY-CL / yoyodyne

Small-vocabulary sequence-to-sequence generation with optional feature conditioning

Apache License 2.0

29 stars 16 forks source link

Closed Adamits closed 11 months ago

Adamits commented 11 months ago

I was not able to run the pointer-generator LSTM. It looks like the breaks have been here since #72.

We now actually pass the encoded features through to the decode_step
We correctly concatenate the feature attention if provided (previously we erroneously concatenated the source attention * 2)
No longer adds the extra breaking dimension to the generation probability.

kylebgorman commented 11 months ago

I just tested some Maori and Polish (the latter has features) and it seems to be working also. Merging now.