Open kylebgorman opened 1 year ago
Going to assign to @Adamits since I think he may be able to bring this back.
Summarizing some discussion we had in person, the heapq
in CPython is actually a pretty snappy implementation (it delegates to a C-based impl called _heapq
which is going to be widely available) so it's probably fine as is. (If you want you can write a wrapper class to make it cuter.) It just needs to be resurrected, tested, and documented.
Beam search is generally not supported by our models, though the flag exists. It appears to be supported in
lstm
; it is unclear to me whether it's supported byfeature_invariant_transformer
,transformer
andtransducer
(if any of these silently ignore the flag, which is what I think happens, this is a serious but easy-to-fix bug), and it's explicitly not implemented inpointer_generator_lstm
.