search

CUNY-CL / yoyodyne

Small-vocabulary sequence-to-sequence generation with optional feature conditioning
Apache License 2.0
25 stars 15 forks source link

Wrap LSTM Outputs in own module class #199

Open bonham79 opened 2 weeks ago

bonham79 commented 2 weeks ago

Current LSTM outputs create ugly typing as mentioned in https://github.com/CUNY-CL/yoyodyne/pull/195. Replace with a dataclass wrapper to make eyes not bleed.

Adamits commented 2 weeks ago

Could you link to an example in the codebase? Dataaclasses are great but I want to apply at least some skepticism to any additions that make things feel further from just pytorch (tensors go in, tensors come out).

kylebgorman commented 2 weeks ago

Could you link to an example in the codebase?

A good example are the two classes here.