Updates new evaluators code to work with Transducer.

CUNY-CL / yoyodyne

Small-vocabulary sequence-to-sequence generation with optional feature conditioning

Apache License 2.0

25 stars 15 forks source link

Updates new evaluators code to work with Transducer. #200

Closed Adamits closed 2 weeks ago

Adamits commented 2 weeks ago

I guess I had forgotten to test the Transducer with this change---it break since it has already "finalized" the prediction tensors. This fixes that by allowing for finalized predictions.

Adamits commented 2 weeks ago

Also @kylebgorman I cannot remember what our convention is---do you need me to create an issue to link this to?

kylebgorman commented 2 weeks ago

Also @kylebgorman I cannot remember what our convention is---do you need me to create an issue to link this to?

Not strictly necessary, no.

Adamits commented 2 weeks ago

@kylebgorman I am not able to see the merge code? Or should I be looking at the other PR?

kylebgorman commented 2 weeks ago

@kylebgorman I am not able to see the merge code? Or should I be looking at the other PR?

Just look at files changed on the right tab.

Adamits commented 2 weeks ago

I only see my changes +your small changes to my comments. When I click the merge commit I see this:

Edit oh I can view the diff from the link... Sorry.

kylebgorman commented 2 weeks ago

I'm just going to merge.