CUQI-DTU / CUQI-Book

Apache License 2.0
0 stars 2 forks source link

Addressing comments from Jakob on the book #56

Closed amal-ghamdi closed 2 months ago

amal-ghamdi commented 2 months ago

Description:

Update the book to address comments from @jakobsj provided in #57

comments are copied and processed here:

Needed now

easy

could wait (moved to #73)

DoD:

amal-ghamdi commented 2 months ago

@jakobsj, would you please review the DoD, I organized the comments from you into three groups. The top group I would like to address today along with #53 in one PR. Thank you. Also feel free to suggest moving the comments along the sections (needed now, easy, can wait)

jakobsj commented 2 months ago

@amal-ghamdi Looks good, approved. (one can always consider if there are other ways. The items are nicely split according to priority like this and will stay together for overview. On the other hand the issue can not be closed as done when only the "needed" ones are done, because the "can wait" ones are also kept here. But let's keep it like this and just focus on getting them done according to priority).

amal-ghamdi commented 2 months ago

@jakobsj , DoD updated based on the discussion today. remaining issues moved to #73