CUQI-DTU / CUQIpy

https://cuqi-dtu.github.io/CUQIpy/
Apache License 2.0
42 stars 9 forks source link

Refactoring wrt. proposal-based sampler including a validate_proposal method instead of proposal.setter #397

Closed nabriis closed 3 months ago

nabriis commented 5 months ago

Issue

Currently samplers implement their own setters for proposals. It makes the code possibly inconsistant in the future.

Suggested change 1) Implement proposal based setting and defaults in base class. 2) Add a validate_proposal abstract method that ensures each subclass must check for valid proposal.