search

CUQI-DTU / CUQIpy

https://cuqi-dtu.github.io/CUQIpy/
Apache License 2.0
41 stars 7 forks source link

Find valid samplers #446

Closed jeverink closed 1 month ago

jeverink commented 1 month ago

Added a method that returns a list of all samplers that should pass validate_target.

Also fixes a bug where the two proposal based samplers are valid for implicit distribution. This fix assumes that implicit distributions return NaN when logd is called, which is currently the case. (Charlie edited: the above is for correctly identifying CWMH and MH as invalid for targets with implicit priors)

Note: I have not checked whether the whether the returned samplers to actually work, so the added tests might not be proper.

closed #447

chaozg commented 1 month ago

This is excellent! @jeverink

nabriis commented 1 month ago

Looks great @jeverink. Will discuss with team on where to put the utility method and its name. But fantastic idea!