Improve ticks of samples.plot

CUQI-DTU / CUQIpy

https://cuqi-dtu.github.io/CUQIpy/

Apache License 2.0

48 stars 9 forks source link

Improve ticks of samples.plot #469

Closed taniagoia11 closed 3 months ago

taniagoia11 commented 3 months ago

Description

when plotting a Continous structure, the plot doesn't show any insight into the variation of the different variables

Example to reproduce

The plot could have the dimensions on the y axis and the values on the x axis

chaozg commented 3 months ago

I agree it doesn't make sense to show floats as x ticks since they are component indices. @taniagoia11 , is the second plot below something close to what you proposed? I forced the x tick to be integers there.
As to x/y labels, I think it's better to leave them to the user and they can be easily set through matplotlib's standard methods, like plt.xlabel("x").

Before:

After:

chaozg commented 3 months ago

Just as @nabriis said, "there is not great solution without being explicit and setting geometry manually", we will keep the existing plot behaviour and leave it to the user. So this issue will be closed.