Acc rate not stored in HybridGibbs sampler

CUQI-DTU / CUQIpy

https://cuqi-dtu.github.io/CUQIpy/

Apache License 2.0

48 stars 9 forks source link

Acc rate not stored in HybridGibbs sampler #483

Closed nabriis closed 2 months ago

nabriis commented 3 months ago

Description

Currently the acceptance rate is not maintained in the HybridGibbs sampler. This means that tuning is not happening using the full acc rate of the chain.

DoD:

[x] HybridGibbs ensures samplers store acc rate while sampling
[x] HybridGibbs maintains state and history of samplers
[x] unit tests are implemented to check the above mentioned behavior

jakobsj commented 2 months ago

@nabriis can you add DoD here please?

nabriis commented 2 months ago

@nabriis can you add DoD here please?

Done