search

CUQI-DTU / CUQIpy

https://cuqi-dtu.github.io/CUQIpy/
Apache License 2.0
44 stars 9 forks source link

Checkpointing nuts #530

Closed amal-ghamdi closed 3 weeks ago

amal-ghamdi commented 1 month ago

closes #404

amal-ghamdi commented 1 month ago

@nabriis This fix enables adding NUTS in the checkpointing tests. It does not address the referred issue fully, but I think we can change the scope of the issue to "Fix NUTS checkpointing tests"

I appreciate it if you can take a look

amal-ghamdi commented 1 month ago

Looks good @amal-ghamdi. Had 1 small comment, and then I wanted to ask if you had looked at state_history_targets?

Do you want to add NUTS to that in this PR? Its related to checkpointing.

Good point, I'll change the issue scope to take care of both history and state.

amal-ghamdi commented 4 weeks ago

Thank you @nabriis, I added NUTS to the list of samplers tested for the history. I also made some updates to the NUTS state for simplification and removing state variables that are not needed. I appreciate it if you can take a look