CUQI-DTU / CUQIpy

https://cuqi-dtu.github.io/CUQIpy/
Apache License 2.0
46 stars 9 forks source link

Add a demo for the truncated Normal #546

Closed amal-ghamdi closed 2 weeks ago

amal-ghamdi commented 1 month ago

DoD

chaozg commented 1 month ago

Hi @jakobsj, could you review the DoD here?

jakobsj commented 1 month ago

I'd like more details on how many (one combined or multiple shorter) notebooks are planned, which and the size of problem(s) to solve, which aspects to cover or leave out. As is, unclear if this is a massive task or a fairly small one. We discussed to complete it within this week as most of the notebook(s) had already been done, so I'd expect it is a smaller task, but please clarify, thanks!

chaozg commented 1 month ago

Hi @jakobsj , I was aiming at two demos at any given (bounded) prior: one for drawing samples and one for solving the simplest BIP. Just updated DoD to reflect this. Could you please help review it again?

jakobsj commented 1 month ago

@chaozg Thank you, DoD approved!

chaozg commented 1 month ago

Hi @jakobsj Could you please help review the DoD here? Instead of testing all bounded priors, which is too ambitious as some priors don't have gradient() yet, the focus of this issue is narrowed to only demonstrate the use of the truncated normal distribution.

jakobsj commented 1 month ago

@chaozg DoD approved (though I would call it one demo with two parts, rather than two demos).

amal-ghamdi commented 2 weeks ago

@chaozg , I am closing this issue :)