search

CURENT / agvis

Geo-visualization for energy system
https://ltb.curent.org
GNU General Public License v3.0
7 stars 5 forks source link

Windows support #60

Closed zmalkmus closed 1 year ago

zmalkmus commented 1 year ago

Added support for Windows OS with the agvis run command.

jinningwang commented 1 year ago

It works well on my Windows laptop, awesome!

One minor concern is that, I noticed that when running command agvis run, it required to be in the path like this "C:\Users\jwang175\agvis\agvis". Is it possible to do some minor adaption that alleviate this so that user can run agvis regardless of the current directory? This might be done in the future as another PR. See andes_root implementation for more information.

The reasons are that:

  1. this is what we do in ANDES and AMS, so it will be more consistent
  2. command agvis can be run regardless current path, so it will be more intuitive to also allow agvis run
zmalkmus commented 1 year ago

I believe I can make app.py do this by setting the path variable.

jinningwang commented 1 year ago

I believe I can make app.py do this by setting the path variable.

Shall I merge this PR and then we do the path variable later or wait for it in this PR?

zmalkmus commented 1 year ago

I believe I can make app.py do this by setting the path variable.

Shall I merge this PR and then we do the path variable later or wait for it in this PR?

It shouldn’t take long to do so I think it is fine to wait until I figure it out.

zmalkmus commented 1 year ago

Jinning, I have now made agvis run start the server from the app.py directory. Let me know if this change works on your machine and we can merge.

jinningwang commented 1 year ago

Jinning, I have now made agvis run start the server from the app.py directory. Let me know if this change works on your machine and we can merge.

It works well on my machine, thanks!