search

CURENT / agvis

Geo-visualization for energy system
https://ltb.curent.org
GNU General Public License v3.0
7 stars 5 forks source link

Unittesting #64

Closed zmalkmus closed 10 months ago

zmalkmus commented 11 months ago

This update changes the backend into an object oriented style, able to be called by the unit tests. The object oriented style allows for the creation of the AgvisWeb class providing the ability to make a new agvis flask application through python (similar to how dime clients are created). This new style also makes the code more readable.

Another huge update is that I was able to successfully integrate GitHub actions here for docker testing. Now when any change is pushed to either the develop or master branches, it runs the docker image and checks if all of the unit tests pass. This also allows for more branch protections, as you can set up GitHub to only allow merging unless all unit tests have passed.

image

As for the unit testing itself, tests were created to handle basic agvis page loading, get and post requests, and command line usage. I created some basic dime tests that work locally, but do not work with the GitHub actions, so I have disabled them unless we really need them in the future. I only created them since all dime unit tests fail even though dime works fine at the moment.

To run the unit tests, enter the /tests folder and run "pytest"

jinningwang commented 10 months ago

Zack, thanks for your hard work!

It shows there are conflicts, can you revolve them?

zmalkmus commented 10 months ago

Hi Jinning,

Thank you!

Yes, I will take a look. I just updated the Dockerfile in both branches for testing so it should be an easy fix.

Would you like me to merge once I am finished?

Thanks, Zack

On Fri, Dec 15, 2023 at 2:02 PM Jinning Wang @.***> wrote:

Zack, thanks for your hard work!

It shows there are conflicts, can you revolve them?

— Reply to this email directly, view it on GitHub https://github.com/CURENT/agvis/pull/64#issuecomment-1858357342, or unsubscribe https://github.com/notifications/unsubscribe-auth/A2WS77FH2XFBZIFWXJCZZP3YJSNFHAVCNFSM6AAAAABALZTFZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGM2TOMZUGI . You are receiving this because you were assigned.Message ID: @.***>

jinningwang commented 10 months ago

Yes, it would be great!

On Fri, Dec 15, 2023 at 15:03 Zack Malkmus @.***> wrote:

Hi Jinning,

Thank you!

Yes, I will take a look. I just updated the Dockerfile in both branches for testing so it should be an easy fix.

Would you like me to merge once I am finished?

Thanks, Zack

On Fri, Dec 15, 2023 at 2:02 PM Jinning Wang @.***> wrote:

Zack, thanks for your hard work!

It shows there are conflicts, can you revolve them?

— Reply to this email directly, view it on GitHub https://github.com/CURENT/agvis/pull/64#issuecomment-1858357342, or unsubscribe < https://github.com/notifications/unsubscribe-auth/A2WS77FH2XFBZIFWXJCZZP3YJSNFHAVCNFSM6AAAAABALZTFZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGM2TOMZUGI>

. You are receiving this because you were assigned.Message ID: @.***>

— Reply to this email directly, view it on GitHub https://github.com/CURENT/agvis/pull/64#issuecomment-1858424526, or unsubscribe https://github.com/notifications/unsubscribe-auth/AS4OJPODPYATGKYEB4KQYD3YJSUJLAVCNFSM6AAAAABALZTFZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJYGQZDINJSGY . You are receiving this because your review was requested.Message ID: @.***>