CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
223 stars 111 forks source link

Dynamic Model (Exciter) Development #176

Closed jinningwang closed 2 years ago

jinningwang commented 2 years ago

Dynamic Model Development

09/22/2022, 2 Prepared: AC8B, IEEET3 Undergoing: ESAC1A, ESST1A, GAST, IEEEVC

1) Developed: AC8B 2) Developed blocks PIDController and PIDAWHardLimiter. 3) Revised block Lag and its related block. Now the constant in denominator 1 is replaced with D. 4) Developed: IEEET3


09/22/2022 Prepared: AC8B Undergoing: IEEET3, ESAC1A, ESST1A, GAST, IEEEVC

1) Developed: AC8B 2) Developed blocks PIDController and PIDAWHardLimiter. 3) Revised block Lag and its related block. Now the constant in denominator 1 is replaced with D.

Trouble: In IEEET3, VTHEV cannot pass andes prep. There is trouble with complex v_str. (3531f1c) Solved: it turned out to be I missed four necessary variables. Now IEEET3 can pass andes prep. Initialization needs to be tested. (3108932)

TODO: Docstring for PIDController and PIDAWHardLimiter may need enhance.

codecov[bot] commented 2 years ago

Codecov Report

Merging #176 (177054b) into develop (d77ec03) will increase coverage by 0.36%. The diff coverage is 99.43%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #176      +/-   ##
===========================================
+ Coverage    78.57%   78.93%   +0.36%     
===========================================
  Files          108      110       +2     
  Lines        11872    12032     +160     
===========================================
+ Hits          9328     9498     +170     
+ Misses        2544     2534      -10     
Impacted Files Coverage Δ
andes/models/__init__.py 100.00% <ø> (ø)
andes/core/block.py 86.87% <98.36%> (+3.08%) :arrow_up:
andes/models/exciter/__init__.py 100.00% <100.00%> (ø)
andes/models/exciter/ac8b.py 100.00% <100.00%> (ø)
andes/models/exciter/ieeet3.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d77ec03...177054b. Read the comment docs.

jinningwang commented 2 years ago

AC8B Prepared

1) Prepared model AC8B. 2) Added an example file and a demo for AC8B.

cuihantao commented 2 years ago

AC8B Prepared

1) Prepared model AC8B.

2) Added an example file and a demo for AC8B.

Thanks. The title of the AC8B notebook needs updating.

jinningwang commented 2 years ago

AC8B Prepared

  1. Prepared model AC8B.
  2. Added an example file and a demo for AC8B.

Thanks. The title of the AC8B notebook needs updating.

Sure, what name style would be appropriate? My plan is '2.x demo_modelname.ipynb', but this can be insufficient.

cuihantao commented 2 years ago

That’s fines. But I mean the title inside the notebook, not the file name. On Sep 21, 2021, 10:38 PM -0500, Jinning Wang @.***>, wrote:

AC8B Prepared

  1. Prepared model AC8B.
  2. Added an example file and a demo for AC8B.

Thanks. The title of the AC8B notebook needs updating. Sure, what name style would be appropriate? My plan is '2.x demo_modelname.ipynb', but this can be insufficient. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

jinningwang commented 2 years ago

That’s fines. But I mean the title inside the notebook, not the file name. …

Okay, I've taken care of it.

jinningwang commented 2 years ago

IEEET3 Prepared

1) Prepared model IEEET3. 2) Added an example file and a demo for IEEET3.

jinningwang commented 2 years ago

@cuihantao Hi Hantao,

I'm curious how you create the ASCII diagram? Maybe it is better to have such a diagram for the PID block: image

Regards, Jinning

cuihantao commented 2 years ago
It was hand crafted. Feel free to use the elements from existing ones.  Sent from Mail for Windows From: Jinning WangSent: Wednesday, September 22, 2021 1:04 PMTo: cuihantao/andesCc: Hantao Cui; MentionSubject: Re: [cuihantao/andes] Dynamic Model (Exciter) Development ***@***.*** Hantao,I'm curious how you create the ASCII diagram?Maybe it is better to have such a diagram for the PID block:Regards,Jinning—You are receiving this because you were mentioned.Reply to this email directly, view it on GitHub, or unsubscribe. 
sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information