Dynamic Model #1 Revision

[jinningwang]

Revised the recently developed AC8B and PID related blocks.

1) Revised AC8B: use PIDTrackAW rather than PIDAWHardLimit. 2) Refactored PIDController and PIDAWHardLimit. 3) Derived PIDTrackAW from PITrackAW.

[codecov[bot]]

Codecov Report

Merging #181 (ced2a89) into develop (9b73d2a) will decrease coverage by 0.17%. The diff coverage is 56.75%.

@@             Coverage Diff             @@
##           develop     #181      +/-   ##
===========================================
- Coverage    78.93%   78.76%   -0.18%     
===========================================
  Files          110      110              
  Lines        12032    12036       +4     
===========================================
- Hits          9498     9480      -18     
- Misses        2534     2556      +22     

Impacted Files	Coverage Δ
andes/core/block.py	82.94% <48.38%> (-3.93%)	:arrow_down:
andes/models/exciter/ac8b.py	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9b73d2a...ced2a89. Read the comment docs.

[cuihantao]

There's an error in the docstring:

/opt/hostedtoolcache/Python/3.7.12/x64/lib/python3.7/site-packages/andes/core/block.py:docstring of andes.core.block.PIDController:15:Inline literal start-string without end-string.

[cuihantao]

It is in this line:

This block assembles a ``PIController``(PIC) and a ``Washout``(WO).

There needs to be a space between `` and the left parenthesis for both.

[jinningwang]

It is in this line:

This block assembles aPIController(PIC) and aWashout(WO).

There needs to be a space between `` and the left parenthesis for both.

I've taken care of them.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[cuihantao]

Sure. You can click on the "Details" to the right of the Azure pipeline, in the checking block above (or below). At the bottom of the new page, find "View more details on Azure Pipelines", and open it. Click on the jobs with an error mark to view the details.

For example, the error was found on this page: https://dev.azure.com/hcui7/hcui7/_build/results?buildId=1817&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=841356e0-85bb-57d8-dbbc-852e683d1642&l=244

Edit: this check was to ensure that documentation will build.

[jinningwang]

Sure. You can click on the "Details" to the right of the Azure pipeline, in the checking block above (or below). At the bottom of the new page, find "View more details on Azure Pipelines", and open it. Click on the jobs with an error mark to view the details.

For example, the error was found on this page: https://dev.azure.com/hcui7/hcui7/_build/results?buildId=1817&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=841356e0-85bb-57d8-dbbc-852e683d1642&l=244

Edit: this check was to ensure that documentation will build.

Thanks for your reply.

It looks like we may need more tests for those newly developed blocks. Will you take care or we can ignore that for time being?

[cuihantao]

It’s difficult to test the blocks individually. We should ensure they are implemented correctly by double checking. Then we can move on.

Regards, Hantao Cui On Sep 26, 2021, 5:13 PM -0500, Jinning Wang @.***>, wrote:

Sure. You can click on the "Details" to the right of the Azure pipeline, in the checking block above (or below). At the bottom of the new page, find "View more details on Azure Pipelines", and open it. Click on the jobs with an error mark to view the details. For example, the error was found on this page: https://dev.azure.com/hcui7/hcui7/_build/results?buildId=1817&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=841356e0-85bb-57d8-dbbc-852e683d1642&l=244 Edit: this check was to ensure that documentation will build. Thanks for your reply. It looks like we may need more tests for those newly developed blocks. Will you take care or we can ignore that for time being? — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

[jinningwang]

It’s difficult to test the blocks individually. We should ensure they are implemented correctly by double checking. Then we can move on. Regards, Hantao Cui

I have tested those PID blocks when testing AC8B, so I think we are good to go.

Regards, Jinning