search

CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
226 stars 111 forks source link

Refactor Exciter Models #182

Closed jinningwang closed 3 years ago

jinningwang commented 3 years ago

1) Added ExcVsum to refactor exciters. 2) Refactored AC8B and IEEET3. 3) Fixed AC8B initialization error. 4) Developed ESAC1A.

Bug reported: Series HVGate and LVGate will result in an initialization error in LVGate. So I use Limiter to avoid it. image

codecov[bot] commented 3 years ago

Codecov Report

Merging #182 (faeddd6) into develop (711f01b) will decrease coverage by 0.19%. The diff coverage is 58.01%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #182      +/-   ##
===========================================
- Coverage    78.76%   78.57%   -0.20%     
===========================================
  Files          110      112       +2     
  Lines        12036    12176     +140     
===========================================
+ Hits          9480     9567      +87     
- Misses        2556     2609      +53
Impacted Files Coverage Δ
andes/models/__init__.py 100.00% <ø> (ø)
andes/models/exciter/esst1a.py 21.42% <21.42%> (ø)
andes/models/exciter/__init__.py 100.00% <100.00%> (ø)
andes/models/exciter/ac8b.py 100.00% <100.00%> (ø)
andes/models/exciter/esac1a.py 100.00% <100.00%> (ø)
andes/models/exciter/excbase.py 100.00% <100.00%> (ø)
andes/models/exciter/ieeet3.py 100.00% <100.00%> (ø)
andes/core/block.py 83.30% <0.00%> (+0.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 711f01b...faeddd6. Read the comment docs.

cuihantao commented 3 years ago

Good idea to separate them.

jinningwang commented 3 years ago

Okay, will we fix the LVGate error? I haven't explored it yet.

cuihantao commented 3 years ago

I’m not sure about the issue. I can look at it tomorrow. On Sep 28, 2021, 11:18 PM -0500, Jinning Wang @.***>, wrote:

Okay, will we fix the LVGate error? I haven't explored it yet. — You are receiving this because you commented. Reply to this email directly, view it on GitHub, or unsubscribe.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information