Prepare for v1.4.3 release

[cuihantao]

@jinningwang Could you fix the "Code Smells" as listed by sonarcloud above? Basically, you will need to remove the unused, comment out code.

I will release a new version once fixed.

[codecov[bot]]

Codecov Report

Merging #190 (f06337a) into master (fd03185) will increase coverage by 0.13%. The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master     #190      +/-   ##
==========================================
+ Coverage   78.76%   78.90%   +0.13%     
==========================================
  Files         110      112       +2     
  Lines       12036    12106      +70     
==========================================
+ Hits         9480     9552      +72     
+ Misses       2556     2554       -2     

Impacted Files	Coverage Δ
andes/models/__init__.py	100.00% <ø> (ø)
andes/models/exciter/exac1.py	100.00% <ø> (ø)
andes/system.py	78.22% <0.00%> (-0.09%)	:arrow_down:
andes/utils/numba.py	33.33% <33.33%> (ø)
andes/core/model.py	78.98% <57.14%> (+0.30%)	:arrow_up:
andes/routines/tds.py	64.09% <70.00%> (+0.02%)	:arrow_up:
andes/core/block.py	83.30% <100.00%> (+0.35%)	:arrow_up:
andes/models/exciter/__init__.py	100.00% <100.00%> (ø)
andes/models/exciter/ac8b.py	100.00% <100.00%> (ø)
andes/models/exciter/esac1a.py	100.00% <100.00%> (ø)
... and 5 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fd03185...f06337a. Read the comment docs.

[jinningwang]

@jinningwang Could you fix the "Code Smells" as listed by sonarcloud above? Basically, you will need to remove the unused, comment out code.

I will release a new version once fixed.

Sure, I will do it now.

[jinningwang]

It seems that the duplication issue occurs again, I will try to refactor recently developed models.

[cuihantao]

@jinningwang Let's not worry about the duplication issues in exciters for now. There are indeed lots of shared, i.e., common blocks, such as the piecewise saturation. We can fix it later.

[jinningwang]

@jinningwang Let's not worry about the duplication issues in exciters for now. There are indeed lots of shared, i.e., common blocks, such as the piecewise saturation. We can fix it later.

Oh, I have refactored the AC8B and ESAC1A. So, do we need to pay attention to the duplication rates?

[cuihantao]

We of course need to pay attention to it, but the solution depends.

It would be helpful if you could fix them now. The duplications in the exciter models are due to the similarity between the models, so it’s containable. Copying and pasting code for the same feature is less acceptable.

From: Jinning Wang @.> Sent: Monday, October 4, 2021 1:33 PM To: cuihantao/andes @.> Cc: Hantao Cui @.>; Author @.> Subject: Re: [cuihantao/andes] Prepare for v1.4.3 release (#190)

@jinningwang https://github.com/jinningwang Let's not worry about the duplication issues in exciters for now. There are indeed lots of shared, i.e., common blocks, such as the piecewise saturation. We can fix it later.

Oh, I have refactored part of the AC8B and ESAC1A. So, do we need to pay attention to the duplication rates?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/cuihantao/andes/pull/190#issuecomment-933747090 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABSNZA27NH2M2F2GGIIDTB3UFHXOJANCNFSM5FJVXDWA . https://github.com/notifications/beacon/ABSNZA24RZZ22LZT7IFYPADUFHXOJA5CNFSM5FJVXDWKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOG6T5TEQ.gif

[sonarcloud[bot]]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
2 Code Smells

No Coverage information
17.9% Duplication