search

CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
223 stars 111 forks source link

Refactored AC8B and ESAC1A #192

Closed jinningwang closed 2 years ago

jinningwang commented 2 years ago

Added new subclass ExcSat in ExcBase. Refactored AC8B and ESAC1A.

codecov[bot] commented 2 years ago

Codecov Report

Merging #192 (f781733) into develop (1010f89) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #192      +/-   ##
===========================================
- Coverage    78.91%   78.90%   -0.01%     
===========================================
  Files          111      111              
  Lines        12107    12103       -4     
===========================================
- Hits          9554     9550       -4     
  Misses        2553     2553
Impacted Files Coverage Δ
andes/models/exciter/ac8b.py 100.00% <100.00%> (ø)
andes/models/exciter/esac1a.py 100.00% <100.00%> (ø)
andes/models/exciter/excbase.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1010f89...f781733. Read the comment docs.

jinningwang commented 2 years ago

Hantao,

I don't really understand this check meaning: image

What's that, and what should I do when developing?

Regards, Jinning

cuihantao commented 2 years ago

It is the percentage of code that got covered in our tests. In software engineering, you want the coverage to be high to at least test if most of the code works. Usually, when new code is written, new tests need to be written.

We can leave it for now since we will need a better structure for unit testing.

jinningwang commented 2 years ago

It is the percentage of code that got covered in our tests. In software engineering, you want the coverage to be high to at least test if most of the code works. Usually, when new code is written, new tests need to be written.

We can leave it for now since we will need a better structure for unit testing.

Thanks for your explanation!

Regards, Jinning

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information