Codecov Report

Merging #200 (ccde557) into develop (6789079) will increase coverage by 0.03%. The diff coverage is 93.25%.

@@             Coverage Diff             @@
##           develop     #200      +/-   ##
===========================================
+ Coverage    78.82%   78.86%   +0.03%     
===========================================
  Files          112      114       +2     
  Lines        12136    12186      +50     
===========================================
+ Hits          9566     9610      +44     
- Misses        2570     2576       +6

Impacted Files	Coverage Δ
andes/core/common.py	`88.41% <ø> (+0.46%)`	:arrow_up:
andes/models/__init__.py	`100.00% <ø> (ø)`
tests/test_case.py	`100.00% <ø> (ø)`
andes/core/var.py	`79.45% <50.00%> (-1.55%)`	:arrow_down:
andes/core/model.py	`79.56% <80.00%> (+0.58%)`	:arrow_up:
andes/models/exciter/esdc2a.py	`100.00% <100.00%> (ø)`
andes/models/exciter/esst4b.py	`100.00% <100.00%> (ø)`
andes/models/exciter/exac4.py	`100.00% <100.00%> (ø)`
andes/models/exciter/excbase.py	`100.00% <100.00%> (ø)`
andes/models/exciter/exdc2.py	`100.00% <100.00%> (ø)`
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6789079...ccde557. Read the comment docs.

jinningwang commented 2 years ago

@cuihantao Hi Hantao,

There is an error with the IEEEVC model, but I cannot figure out how to fix it.

IEEEVC will inject a compensate voltage vcomp into Exciter vi, but then Exciter vi will have an initialization mismatch error. I failed to figure out how to fix the initialization value. How to deal with the controlled var's initialization value?

The notebook file is located in: 'examples/demonstration/test_IEEEVC.ipynb'

Regards, Jinning

cuihantao commented 2 years ago

Thanks for the contributions! I will work on it!

Regards, Hantao Cui On Oct 8, 2021, 5:32 PM -0500, Jinning Wang @.***>, wrote:

Hi Hantao, There is an error with the IEEEVC model, but I cannot figure out how to fix it. IEEEVC will inject a compensate voltage vcomp into Exciter vi, but then Exciter vi will have an initialization mismatch error. I failed to figure out how to fix the initialization value. Can you take a look at it? The notebook file is located in: 'examples/demonstration/test_IEEEVC.ipynb' Regards, Jinning — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

jinningwang commented 2 years ago

Got it, I will test it.

Thanks!