jinningwang commented 2 years ago

Hantao,

Based on the PowerWorld and PSSE reference, I think there is an error in the TGOV1 equation, so I fix it. Please double check my corrections.

Regards, Jinning

Notes:

https://www.powerworld.com/WebHelp/Content/TransientModels_PDF/Generator/Governor/Governor%20TGOV1.pdf

codecov[bot] commented 2 years ago

Codecov Report

Merging #207 (49d3f13) into master (21f0c71) will increase coverage by 0.05%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master     #207      +/-   ##
==========================================
+ Coverage   78.79%   78.85%   +0.05%     
==========================================
  Files         115      116       +1     
  Lines       12223    12256      +33     
==========================================
+ Hits         9631     9664      +33     
  Misses       2592     2592

Impacted Files	Coverage Δ
andes/models/governor/tgov1.py	`87.67% <66.66%> (ø)`
andes/models/governor/__init__.py	`100.00% <0.00%> (ø)`
andes/models/governor/gast.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 21f0c71...49d3f13. Read the comment docs.

cuihantao commented 2 years ago

The current implementation is correct because dw is the negative of that in the diagram.

There would be a positive feedback if this issue exists.

cuihantao commented 2 years ago

Maybe you can invert the sign of dw to make it the same as the diagram?

Also check if it affects derived models such as TGOV1N, TGOV1DB and TGOV1NDB.

jinningwang commented 2 years ago

Maybe you can invert the sign of dw to make it the same as the diagram?

Also check if it affects derived models such as TGOV1N, TGOV1DB and TGOV1NDB.

Oh, I just noticed that, sorry for my misunderstanding.

The sign of wd has been modified.