jinningwang commented 2 years ago

Fixed initialization error of REGCA1 when Low Voltage Management is activated initially.

Please try ieee14/ieee14_solar_abn.xlsx, where the REGCA1.Lvpnt1 is set at 1.4 to trigger the Low Voltage management initially.

codecov[bot] commented 2 years ago

Codecov Report

Merging #239 (f68bbb2) into develop (24c133f) will increase coverage by 0.10%. The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #239      +/-   ##
===========================================
+ Coverage    78.40%   78.50%   +0.10%     
===========================================
  Files          150      151       +1     
  Lines        12775    12835      +60     
===========================================
+ Hits         10016    10076      +60     
  Misses        2759     2759

Impacted Files	Coverage Δ
andes/models/renewable/regca1.py	`98.41% <100.00%> (ø)`
andes/models/governor/__init__.py	`100.00% <0.00%> (ø)`
andes/models/governor/hygov.py	`100.00% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 24c133f...f68bbb2. Read the comment docs.

cuihantao commented 2 years ago

The low voltage management gain is tested fixed. Thanks for your help!

The high-voltage management gain needs fixing as well. You can replicate an issue in ieee14_solar_abn.xlsx by changing Lvpnt1 to 1.0 and setting Volim to 0.9. An initialization error will appear for Qe.

jinningwang commented 2 years ago

Hantao,

I explained the Volim in the docstring.

Regards, Jinning