Closed jinningwang closed 2 years ago
Merging #240 (9d4bc1d) into develop (641e9ba) will increase coverage by
0.00%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## develop #240 +/- ##
========================================
Coverage 78.50% 78.50%
========================================
Files 151 151
Lines 12835 12837 +2
========================================
+ Hits 10076 10078 +2
Misses 2759 2759
Impacted Files | Coverage Δ | |
---|---|---|
andes/models/governor/hygov.py | 100.00% <ø> (ø) |
|
andes/models/renewable/reeca1.py | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 641e9ba...9d4bc1d. Read the comment docs.
Hi @jinningwang, just want to check if you received notifications of the comments above. Thanks.
Hi @jinningwang, just want to check if you received notifications of the comments above. Thanks.
Hi Hantao,
I checked the code and s4in should be removed since it is not used anymore.
Regards, Jinning
Kudos, SonarCloud Quality Gate passed!
No. 1 When SWV_s0 = 1, SWPF_s0 =1, PIV_input = Vref1 + Qref – Vt, which should be 0, so I fixed the equations of Qref.
No. 2 Also, when SWPF_s0 =1, it means PIQ is out of use, I fixed its input equation to make sure it is 0. The input equation of PIQ is changed to make sure the input is 0.
No. 3 When SWQ_s0 = 1, SWPF_s0 =1, S4_input = PFsel / vp, which should be Iqcmd0. However, the Qref is set by PIV, so I add an additional constant value in s4_input.