search

CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
224 stars 111 forks source link

DelayVec #248

Closed jinningwang closed 2 years ago

jinningwang commented 2 years ago
  1. Developed DelayVec.
  2. Developed EVTD which applies DelayVec.

Hi Hantao,

I developed the DelayVec which supports vector input. The code is tested to work well as shown in the Demo.

image image

Thanks for your guidance! You can take a look at the code but we can close this PR and merge the PR when I finish the EV model.

Regards, Jinning

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

codecov[bot] commented 2 years ago

Codecov Report

Merging #248 (de6eb3f) into develop (aa4567c) will decrease coverage by 0.09%. The diff coverage is 52.17%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #248      +/-   ##
===========================================
- Coverage    78.51%   78.41%   -0.10%     
===========================================
  Files          151      151              
  Lines        12841    12885      +44     
===========================================
+ Hits         10082    10104      +22     
- Misses        2759     2781      +22
Impacted Files Coverage Δ
andes/models/__init__.py 100.00% <ø> (ø)
andes/core/discrete.py 75.73% <29.03%> (-2.64%) :arrow_down:
andes/models/distributed/__init__.py 100.00% <100.00%> (ø)
andes/models/distributed/ev.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aa4567c...de6eb3f. Read the comment docs.

cuihantao commented 2 years ago

Great. You might want to let self.delay be a NumParam that can be specified in the case file.

jinningwang commented 2 years ago

Great. You might want to let self.delay be a NumParam that can be specified in the case file.

Yes, I put it as td in the EVTD. Thanks!

jinningwang commented 2 years ago

Hantao,

I will close this PR for now, we will reopen it when necessary.

Regards, Jinning