search

CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
211 stars 110 forks source link

REPCA1fix #269

Closed jinningwang closed 2 years ago

jinningwang commented 2 years ago

Fix the bug that occurred with the PSSE parser.

codecov[bot] commented 2 years ago

Codecov Report

Merging #269 (93c1075) into develop (6b8afff) will decrease coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #269      +/-   ##
===========================================
- Coverage    78.81%   78.81%   -0.01%     
===========================================
  Files          152      152              
  Lines        12908    12909       +1     
===========================================
  Hits         10174    10174              
- Misses        2734     2735       +1
Impacted Files Coverage Δ
andes/models/renewable/repca1.py 100.00% <ø> (ø)
andes/models/renewable/wtdta1.py 100.00% <100.00%> (ø)
andes/routines/pflow.py 69.18% <0.00%> (-0.44%) :arrow_down:
andes/core/param.py 77.65% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6b8afff...93c1075. Read the comment docs.

jinningwang commented 2 years ago

Hantao,

Although the file conversion can run now, there is one thing that is not solved that well. When the REPCA1 is set as the local mode, the file conversion will run into an error that will NOT abort the file conversion. The error is caused that the input of bus1 and bus2 being 0, which will not specify a line. I didn't find a better solution to solve this error, do you think it is necessary to do it by code, or we can specify these details in the documentation.

Error: <REPCA1> cannot retrieve <bus1> from <ACLine> using <line>:
  KeyError('Group <ACLine> does not contain device with idx=False')
jinningwang commented 2 years ago

Hantao,

I added a declaration about the PSSE parser in the REPCA1 and WTDTA1 models docstring. Hope this will be helpful to our users.

Regards, Jinning

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information