CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
211 stars 110 forks source link

Refactor WTDTA1 #280

Closed jinningwang closed 2 years ago

jinningwang commented 2 years ago

Refactor WTDTA1 and its PSSE parser

Additional comment:

In the equation of Kshaft, set 2*pi*Freq1 in per unit will make more sense:

image
jinningwang commented 2 years ago

Hantao,

I refactored the WTDTA1, now we have no more trouble with the model and its PSSE parser.

Regards, Jinning

codecov[bot] commented 2 years ago

Codecov Report

Merging #280 (bb5b383) into develop (7803452) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #280   +/-   ##
========================================
  Coverage    78.82%   78.82%           
========================================
  Files          152      152           
  Lines        12918    12919    +1     
========================================
+ Hits         10183    10184    +1     
  Misses        2735     2735           
Impacted Files Coverage Δ
andes/models/renewable/wtdta1.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7803452...bb5b383. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

cuihantao commented 2 years ago

Just merged. Thanks!!