CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
208 stars 108 forks source link

Revision of pandapower interface #307

Closed jinningwang closed 2 years ago

jinningwang commented 2 years ago
codecov[bot] commented 2 years ago

Codecov Report

Merging #307 (47a52b5) into develop (ff25615) will increase coverage by 0.15%. The diff coverage is 78.94%.

@@             Coverage Diff             @@
##           develop     #307      +/-   ##
===========================================
+ Coverage    77.91%   78.07%   +0.15%     
===========================================
  Files          160      160              
  Lines        13715    13704      -11     
===========================================
+ Hits         10686    10699      +13     
+ Misses        3029     3005      -24     
Impacted Files Coverage Δ
andes/interop/pandapower.py 89.31% <69.23%> (+8.91%) :arrow_up:
tests/test_pandapower.py 95.65% <100.00%> (+0.53%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ff25615...47a52b5. Read the comment docs.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

cuihantao commented 2 years ago

Let me know if it's okay to be merged.

jinningwang commented 2 years ago

Let me know if it's okay to be merged.

Hantao,

I think it is ready to merge now, I have tested it on my end and all functions run well.

Regards, Jinning