CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
224 stars 111 forks source link

Fix pandapower add_gencost #309

Closed jinningwang closed 2 years ago

jinningwang commented 2 years ago

Change add_gencost to work on all generators rather than controllable ones, which will be easier to use if there are uncontrollable generators that will participate in scheduling later

jinningwang commented 2 years ago

Hantao,

Sorry for annoying you again, there is a minor change to the pandapower interface function. It is ready to merge now.

Regards, Jinning

codecov[bot] commented 2 years ago

Codecov Report

Merging #309 (45d3415) into develop (e520590) will decrease coverage by 0.28%. The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           develop     #309      +/-   ##
===========================================
- Coverage    78.07%   77.78%   -0.29%     
===========================================
  Files          160      170      +10     
  Lines        13704    13890     +186     
===========================================
+ Hits         10699    10805     +106     
- Misses        3005     3085      +80     
Impacted Files Coverage Δ
andes/interop/pandapower.py 89.31% <0.00%> (ø)
andes/models/timer.py 68.55% <0.00%> (-2.88%) :arrow_down:
andes/routines/tds.py 63.00% <0.00%> (-0.61%) :arrow_down:
andes/system.py 76.09% <0.00%> (-0.37%) :arrow_down:
andes/core/service.py 84.13% <0.00%> (-0.24%) :arrow_down:
andes/models/group.py 94.98% <0.00%> (ø)
andes/utils/snapshot.py 100.00% <0.00%> (ø)
andes/models/__init__.py 100.00% <0.00%> (ø)
andes/core/model.py
andes/core/model/modelcall.py 64.28% <0.00%> (ø)
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e520590...45d3415. Read the comment docs.

cuihantao commented 2 years ago

That's totally fine.

Can you add a line in release-notes.rst and briefly describe what was changed? Please follow the format closely: each bullet item begins with -, and the continuation of a line for the same bullet item should be indented by two spaces.

jinningwang commented 2 years ago

That's totally fine.

Can you add a line in release-notes.rst and briefly describe what was changed? Please follow the format closely: each bullet item begins with -, and the continuation of a line for the same bullet item should be indented by two spaces.

Sure thing, I briefly described the changes I made.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information