search

CURENT / andes

Python toolbox / library for power system transient dynamics simulation with symbolic modeling and numerical analysis 🔥
https://ltb.curent.org
Other
208 stars 108 forks source link

Fix equation for `Ipcmd`. #338

Closed cuihantao closed 2 years ago

cuihantao commented 2 years ago

This PR fixes an equation issue in REGCA1 for the Ipcmd equation. Ipcmd should stay constant if no controller attached but was incorrectly set to vary with the Low Voltage Power Management loop.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 2 years ago

Codecov Report

Merging #338 (39126b3) into develop (f3b47d7) will increase coverage by 0.00%. The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #338   +/-   ##
========================================
  Coverage    78.07%   78.07%           
========================================
  Files          170      170           
  Lines        14151    14153    +2     
========================================
+ Hits         11048    11050    +2     
  Misses        3103     3103
Impacted Files Coverage Δ
andes/models/renewable/regca1.py 98.48% <100.00%> (+0.04%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f3b47d7...39126b3. Read the comment docs.