PR #530 follow up - Githubissues

jinningwang commented 2 months ago

Fill dae data from loaded csv file by a helper function _csv_data_to_dae()

cuihantao commented 2 months ago

Oh the test looks good!

Get Outlook for iOShttps://aka.ms/o0ukef

From: Jinning Wang @.> Sent: Tuesday, April 16, 2024 4:36:11 PM To: CURENT/andes @.> Cc: Hantao Cui @.>; Review requested @.> Subject: Re: [CURENT/andes] PR #530 follow up (PR #533)

@jinningwang commented on this pull request.

In andes/routines/tds.pyhttps://github.com/CURENT/andes/pull/533#discussion_r1567967227:

@@ -1108,3 +1090,22 @@ def check_criteria(self): res = deltadelta(self.system.dae.x[self.system.SynGen.delta_addr], self.config.ddelta_limit) return res +

def _csv_output(self):

The changed lines are covered by following tests. Do you mean a test on the helper function itself? https://github.com/CURENT/andes/blob/7f56cc9ea4c16d9d58f5b440984f7ee2e6fd1018/tests/test_output.py#L78-L129

— Reply to this email directly, view it on GitHubhttps://github.com/CURENT/andes/pull/533#discussion_r1567967227, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABSNZA2KNQFKU5PRWU67W3DY5WKUXAVCNFSM6AAAAABGGFCRLSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDAMBUGYZTSMRVGY. You are receiving this because your review was requested.Message ID: @.***>

cuihantao commented 2 months ago

Jinning, thanks a lot!

CURENT / andes

PR #530 follow up #533