search

CUTR-at-USF / MUSER

App used in USF research on music therapy. Based on Shuttle Music Player (https://github.com/timusus/Shuttle).
Other
2 stars 1 forks source link

Blacklisting doesn't remove song from playlist. #114

Open BumbleFlash opened 3 years ago

BumbleFlash commented 3 years ago

Describe the bug Blacklisting the song removes the song from the library but doesn't remove the song from the playlist.

To Reproduce Steps to reproduce the behavior:

  1. Click on the Overflow Button (Triple vertical dot) song/album
  2. Click on Blacklist
  3. Go to the playlist to which the song was added
  4. The song still exists.

Expected behavior The song should be hidden from the playlist.

Observed behavior The song still shows up on the playlist

Device and Android version:

Google Pixel 3a, Android 11, Stock, Google Play Services 20.45.16

barbeau commented 3 years ago

We should rename from "Blacklist" to "Disable".

I would expect that the song remain on the playlist, but just be faded to indicate that it's disabled as proposed in https://github.com/CUTR-at-USF/MUSER/issues/115 and the song would be skipped when the player gets to that point in the playlist. That way if a user "enables" the song later, their playlists are still intact. If they want to remove it from a playlist, they can choose the "remove from playlist" option (which still remains to be implemented).