search

CUTR-at-USF / MUSER

App used in USF research on music therapy. Based on Shuttle Music Player (https://github.com/timusus/Shuttle).
Other
2 stars 1 forks source link

Remove LeakCanary before release #19

Closed BumbleFlash closed 4 years ago

BumbleFlash commented 4 years ago

Is your feature request related to a problem? Please describe. LeakCanary is pushing notifications about memory leaks and it's constantly freezing the app while dumping into memory. It should be removed from the app so that we don't confuse users with unnecessary information.

Describe the solution you'd like Remove the library and its implementation from the code.

Describe alternatives you've considered Abstract its service from the user. Log any memory issues instead of pushing notifications.

BumbleFlash commented 4 years ago

Also, I found another method where we can build a No-Op version of LeakCanary. Please check out this Stackoverflow forum for more information.

BumbleFlash commented 4 years ago

Correction: The No-Op version is already implemented in the gradle file of the dev Branch.

barbeau commented 4 years ago

I'm assuming the no-op implementation is for release builds, and the one that logs issues is only on debug builds. But for our purposes, we can remove it entirely.

BumbleFlash commented 4 years ago

Great. I have opened a pull request that comments out all the LeakCanary codes.

barbeau commented 4 years ago

Closed by https://github.com/CUTR-at-USF/MUSER/pull/21