CUTR-at-USF / MUSER

App used in USF research on music therapy. Based on Shuttle Music Player (https://github.com/timusus/Shuttle).
Other
2 stars 1 forks source link

Add new MUSER icon #42

Closed barbeau closed 4 years ago

barbeau commented 4 years ago

Is your feature request related to a problem? Please describe. The existing MUSER icon was a placeholder - we should replace it with an actual icon, and preferrably using Android adaptive icons:

Describe the solution you'd like Here are two mockups for Android's Adaptive icons, one that uses a blue background with a record player in the foreground, and one that uses the record as the foreground and the player as the background:

Screen Shot 2020-08-03 at 7 54 23 PM (2)

Screen Shot 2020-08-03 at 7 38 22 PM (2)

Per discussions we prefer the 2nd with the record player as the foreground. We'll get assets for this and load them up.

Describe alternatives you've considered Don't use adaptive icons

barbeau commented 4 years ago

Here's the latest SVG for the adaptive icon (GitHub doesn't support attaching SVGs directly, so it's zipped):

adaptive-icon2.zip

barbeau commented 4 years ago

Separate foreground and background for adaptive icon:

foreground-background.zip

barbeau commented 4 years ago

I’m running into an issue when using the Android Studio "New->Image Asset" wizard to add the foreground layer. I get the message that the “foreground image may not be complete due to encountered issues”, and when I click on details I get the below message.

So it looks like line 23 <image> tag isn’t supported by Android Studio.

I’ll continue to try and troubleshoot. See the warnings too – looks like these aren’t fatal but I’m not sure how they would impact the final image yet.

image

barbeau commented 4 years ago

line 23 <image> tag appears to be the highlights on the record.

BumbleFlash commented 4 years ago

I have used the below tool before to generate vector assets and it did seem to be compatible with Android studio. However, it looks like it has been deprecated. Since Shuttle's codebase is pretty outdated I think this tool may help us get rid of this issue. Let me know if you found this useful.

http://inloop.github.io/svg2android/

barbeau commented 4 years ago

Here's the output of that tool for the foreground image:

Warning #1: | found attribute 'fill-rule:evenodd' which is supported only on Android API 24 and higher - ([more info](https://github.com/inloop/svg2android/issues/44))
Warning #2: | found fill(s) or stroke(s) which uses url() (gradients and patterns are not supported in Android)
Warning #3: | image element is not supported, you must vectorize raster image
Warning #4: | transforms on path are not supported, use option Bake transforms into path

So unfortunately seems like it has the same issue with Warning 3, and the output looks broken look when I load the XML file into Android Studio and preview it:

image

I get the error in Android Studio when running the wizard before even completing it and generating the icons, so it doesn't seem that the issue is with the Shuttle codebase, but with the Android raster/vector conversion utilities (i.e., what the above tool tells you to use) just not supporting certain SVG features.