search

CUTR-at-USF / MUSER

App used in USF research on music therapy. Based on Shuttle Music Player (https://github.com/timusus/Shuttle).
Other
2 stars 1 forks source link

Update Firebase version for Remote Config #97

Open barbeau opened 3 years ago

barbeau commented 3 years ago

Is your feature request related to a problem? Please describe.

I got the below email from Firebase.

We are writing to let you know that we are deprecating older versions of the Android and iOS Remote Config SDK. After May 2, 2021, these SDKs will no longer be supported and will not be able to fetch from Remote Config.

What happened? In order to streamline Remote Config and offer new features, we will be turning down the legacy API these older SDKs depend on.

What’s next? To continue using Remote Config, be sure to upgrade your apps to SDK version 16.3.0+ for Android and 6.3.0+ for iOS before May 2, 2021. Once this date has passed, your app will no longer be able to fetch values from Remote Config and will fall back to the last fetched values or the default values within your app.

Please take a look at our instructions for Android and iOS.

The following project(s) linked below are currently using the affected SDKs, and will need to be upgraded:

MUSER (muser-1d7ac) Note that this list may include projects you’ve already upgraded as some older versions of your app may still be in use.

Describe the solution you'd like Update Firebase SDK version

BumbleFlash commented 3 years ago

@barbeau The next valid version for Firebase to upgrade to would be 17.1.0. As discussed in this issue https://github.com/CUTR-at-USF/MUSER/issues/25 here, we may not able to upgrade it unless we fix the issues that are stopping us from upgrading to androidx.

barbeau commented 3 years ago

@BumbleFlash Ok, thanks for looking at this. I think this is only an issue for Remote Config? Since we're not using that I'd say let's wait then. I'll change the milestone to be post MVP but we can move back if we find this is critical.

BumbleFlash commented 3 years ago

@barbeau Looks like Shuttle code uses remote config after I found the dependency added to the Gradle file. Should we prioritize migrating androidx at some point?

barbeau commented 3 years ago

@BumbleFlash What is it used for?

BumbleFlash commented 3 years ago

@barbeau From a high-level Ctrl+Shift+F search on the project, it looks like the RemoteConfig is being used with the SnowFall view that's being used in the PlayerFragment.java. https://github.com/CUTR-at-USF/MUSER/blob/usf/app/src/main/java/com/simplecity/amp_library/ui/views/SnowfallView.java#L143

barbeau commented 3 years ago

Huh - I guess you could remotely trigger a snowfall scene in the app? Now I'm curious just to know what that looks like :). But given that's not a feature we're using, I suppose it's fine if it breaks. So I'd be inclined to ignore this for now unless we figure out that something else with Firebase is going to break.