Open vreixo opened 10 years ago
I have finished to modify the file adding all the strings that should be reviewed, commented in English (some where also omitted in previous translations).
Some strings probably are perfect with the previous contents because the languages are different and some terms probably are more or less used or technical in one language or another. I just have replaced them in all the cases that they were changed and contents were not exactly the same, so could be worth it to try to adapt it more closely to the English simplified version (avoiding the use of request, parameter, making warnings softer with "Something went wrong" or similar, etc.).
I think, @barbeau, that maybe is better to let this issue open after merge the pull request that I will do and wait for the translation, hence it will be also referencing this issue, so we won't have a lot of them for the same thing.
I have added some notes inside of some the commented new strings (all in caps to difference them well) in some cases that the change with previous version is very subtle in which the reason for the change may go unnoticed.
I have a doubt because I kind of remember something about auto-closing and this has happened twice. This issue was auto-closed because I have putted "Fix #190 - " in commit, in pull request or just you do it to keep things organized?
Yes, when pull requests are merged to master branch Github will automatically close any fixed issues referenced in commit message. Feel free to reopen any issues if needed.
OK, so I will need to reopen or change commits for another issue. The problem is that I think that I don't have permissions to reopen issues opened by others (or maybe I don't know how to do it).
@diegoguidotti I have commented once again some of the strings, because we forgot to warn you and specify that some of the strings have changed their meaning on a previous update from English ones.
So, will be great if you can take a look at them again an translate the commented ones, as you did last time.
I'm sorry for the inconveniences of work with the files two times for the same release, but we're still getting used to the new system to contribute on translations.
I also paste again @barbeau instructions to remember the details of the process:
@diegoguidotti We've added a few new lines of English text to the OTP Android project, which are currently commented out in the Italian translation: https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/blob/master/opentripplanner-android/src/main/res/values-it/strings.xml
We see you've contributed Italian translations in the past.
Would you be willing to take a few minutes to uncomment and update the new text in the above strings.xml file?
You can edit the file directly via the above Github page link, and submit a pull request from there.
You can read more about the new process we're using to maintain translations here.
Thanks!
Thanks!
@diegoguidotti We've added a few new lines of English text to the OTP Android project, which are currently commented out in the Italian translation: https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/blob/master/opentripplanner-android/src/main/res/values-it/strings.xml
We see you've contributed Italian translations in the past.
Would you be willing to take a few minutes to uncomment and update the new text in the above strings.xml file?
You can edit the file directly via the above Github page link, and submit a pull request from there.
Thanks!
In last major strings update, @barbeau has made same great changes to reduce the complexity of the messages, changing words as server, metadata, etc. by some more common use ones.
Unfortunately we forgot to clearly mention this before we ask for last contributions on translations so we will need to ask again for an update.
First I will update the structure and replace these string that have changed their original contents for the new English versions (so the process will be the the same as for new strings as was discussed in #170). Once this is done will be great if a contributor can check all this new values and translate them accordingly.