search

CUTR-at-USF / OpenTripPlanner-for-Android

An Android app for multi-modal trip planning and navigation using any OpenTripPlanner server.
Other
130 stars 91 forks source link

Fix #413 - Modified separator from : to _. #414

Closed vreixo closed 9 years ago

barbeau commented 9 years ago

@vreixo thanks! But, looks like one of the tests failed due to bounds changing?

edu.usf.cutr.opentripplanner.android.tasks.TripRequestTest > testRequestPlan[test(AVD) - 4.4.2] FAILED 
    junit.framework.AssertionFailedError: expected:<43.352762687773925> but was:<43.3527635495014>
    at edu.usf.cutr.opentripplanner.android.tasks.TripRequestTest.testRequestPlan(TripRequestTest.java:90)

If this is from a live server, we should change to using bundled JSON to avoid failures not related to source or OTP directory contents.

barbeau commented 9 years ago

Thanks @vreixo! When you have a chance, please open a new ticket for changing the test accordingly.

vreixo commented 9 years ago

@barbeau commit it's already here and accepted. Do you still prefer a new ticket?

barbeau commented 9 years ago

@vreixo Sorry - I meant a new ticket for testing within app only - I'm not sure of the utility of testing against a live server whose response is expected to change. Instead, we should probably test again static sources so only code changes (or incorrect entries in OTP Server Directory) trigger build failures. That being said, I haven't had the opportunity to look at the new tests in-depth, so I might be misunderstanding what is going on here.

barbeau commented 9 years ago

@vreixo In other words, this PR is fine the way it is now (and merged), but we should probably make changes in the future how we're handing this.

vreixo commented 9 years ago

@barbeau I agree that would be an improvement to check against a mock server. Although if the server is one that is controlled (now only runs in my server) and test is updated if server is changed will be ok, because the request it's exactly the same (same date also) so the reply will be the same meanwhile the server stays unchanged.

The problem here was that I had added another gtfs source and downloaded new osm data to match the bigger area without updating it. El 10/09/2014 12:04, "Sean Barbeau" notifications@github.com escribió:

@vreixo https://github.com/vreixo In other words, this PR is fine the way it is now (and merged), but we should probably make changes in the future how we're handing this.

— Reply to this email directly or view it on GitHub https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/414#issuecomment-55138560 .