search

CUTR-at-USF / OpenTripPlanner-for-Android

An Android app for multi-modal trip planning and navigation using any OpenTripPlanner server.
Other
129 stars 91 forks source link

Incorrect lat/lng format for servers on 0 coordinates (Aquitaine) #436

Closed vreixo closed 10 years ago

vreixo commented 10 years ago

On this servers 0 won't be correctly taken and point on map functionality won't work, coordinates are going to be 34.324,-.4566 for example. @kalon33 did you not have any problems with this?

kalon33 commented 10 years ago

@vreixo when should this happen? How to reproduce it? Maybe I triggered this one but wasn't able to identify the source.

----- Mail original -----

De: "Vreixo González Caneda" notifications@github.com À: "CUTR-at-USF/OpenTripPlanner-for-Android" OpenTripPlanner-for-Android@noreply.github.com Cc: "Nicolas Derive" kalon33@ubuntu.com Envoyé: Vendredi 12 Septembre 2014 12:06:58 Objet: [OpenTripPlanner-for-Android] Incorrect lat/lng format for servers on 0 coordinates (Aquitaine) (#436)

On this servers 0 won't be correctly taken and point on map functionality won't work, coordinates are going to be 34.324,-.4566 for example. @kalon33 did you not have any problems with this?

— Reply to this email directly or view it on GitHub .

vreixo commented 10 years ago

@kalon33 this was not crashing the app and it's very easy to see. Just long press on the map and set origin or destination, and look to the origin/destination text box, you will see something like 44.83791, -.57954 (note the absence of 0). This is the lat/lng used for geocoding so, it will show a pop-up saying that was not possible to obtain an address for the localization (or something similar in French :-))

kalon33 commented 10 years ago

@ vreixo : sure I triggered that one! And I had this message! But couldn't identify what the cause was.

So a fix should be made that add the "0", only for servers using master?

----- Mail original -----

De: "Vreixo González Caneda" notifications@github.com À: "CUTR-at-USF/OpenTripPlanner-for-Android" OpenTripPlanner-for-Android@noreply.github.com Cc: "Nicolas Derive" kalon33@ubuntu.com Envoyé: Vendredi 12 Septembre 2014 12:34:13 Objet: Re: [OpenTripPlanner-for-Android] Incorrect lat/lng format for servers on 0 coordinates (Aquitaine) (#436)

@kalon33 this was not crashing the app and it's very easy to see. Just long press on the map and set origin or destination, and look to the origin/destination text box, you will see something like 44.83791, -.57954 . This is the lat/lng used for geocoding so, it will show a pop-up saying that was not possible to obtain an address for the localization (or something similar in French :-))

— Reply to this email directly or view it on GitHub .

vreixo commented 10 years ago

Well it's really to change the format to all the servers, but won't be noticed for servers not crossing 0.x lat/lng, you can check the fix here https://github.com/CUTR-at-USF/OpenTripPlanner-for-Android/pull/437/files.

This is not really related to OTP, it's just the internal geocoding of the app against external providers, like Android Geocoder or Nominatim.