Add quiet option, fix field width issue, addPy 3 compatibility

CUTR-at-USF / gtfsrdb

GTFSrDB is a tool to archive gtfs-realtime data to a database.

Other

39 stars 13 forks source link

Add quiet option, fix field width issue, addPy 3 compatibility #6

Closed fitnr closed 7 years ago

fitnr commented 7 years ago

These commits:

Run an automatic PEP8 formatter
Use wider fields for route_id and trip_id (Many systems use more than 10 characters for these values
Adds a quiet option, managed by logging
Adds python3 compatibility for the heck of it, since it's only a two-line change after the above

CLAassistant commented 7 years ago

All committers have signed the CLA.

barbeau commented 7 years ago

Thanks @fitnr!

@jadorno Would you be able to review this PR?

jadorno commented 7 years ago

@barbeau Sure thing. I will review this pull request in the next 24-48 hours. (I'm currently in an airport waiting on connecting flights)

Just a heads up (without looking at the exact edits of the code), if there's changes to the database structure, the script will become incompatible with previously created databases.

fitnr commented 7 years ago

The only db changes are to extend certain field sizes (from String(10) to String(64)). Loading data into databases created with previous versions should be able to proceed with no issues.